GH-116968: Remove branch from advance_backoff_counter #124469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iritkatriel
reviewed
Oct 3, 2024
| backoff_counter_triggers(_Py_BackoffCounter counter) | ||
| { | ||
| return counter.value == 0; | ||
| /* Test whether the value is zero and the backoff is not UNREACHABLE_BACKOFF */ |
There was a problem hiding this comment.
It's not testing that the value is zero. Is this comment accurate?
There was a problem hiding this comment.
Yes it is testing whether the value is zero. The value is the high bits, so value == 0 for any value_and_backoff < (1 << BACKOFF_BITS)
iritkatriel
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the branch from
advance_backoff_counterso that it is just an increment, as the name suggests.